-
Notifications
You must be signed in to change notification settings - Fork 534
Adding Automatic-Module-Name to MANIFEST #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Automatic-Module-Name to MANIFEST #411
Conversation
…y Java9 modularized applications.
@@ -8,6 +8,12 @@ dependencies { | |||
} | |||
test.useTestNG() | |||
|
|||
jar { | |||
manifest { | |||
attributes('Automatic-Module-Name': 'org.reactivestreams.flowbridge') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flowbridge
has been renamed to flowadapters
Thanks @kiiadi! |
Though mostly just for the sake of consistency, please add these to all modules (tck, examples)? |
Looks good in general though, adding this metadata is very important indeed |
@viktorklang your commit looks fine to me - let's go with that - we can close this PR. |
(I commented on the commit, not sure you saw that Victor — all good, would likely drop the api name in the module but having is is still legal) |
@kiiadi You sure? I'd prefer to have you on that commit id :) |
@ktoso I don't mind either way. We can drop the "api" suffix on the primary RS jar |
@reactive-streams/contributors I'll merge this and then add the other module names in a separate PR. Thanks @kiiadi! |
So that the API and flow-bridge it can be consumed by Java9 modularized applications.