Skip to content

Adding Automatic-Module-Name to MANIFEST #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kiiadi
Copy link
Contributor

@kiiadi kiiadi commented Nov 13, 2017

So that the API and flow-bridge it can be consumed by Java9 modularized applications.

@@ -8,6 +8,12 @@ dependencies {
}
test.useTestNG()

jar {
manifest {
attributes('Automatic-Module-Name': 'org.reactivestreams.flowbridge')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flowbridge has been renamed to flowadapters

@viktorklang
Copy link
Contributor

Thanks @kiiadi!
Does it make sense to add module names to the TCK also?

@ktoso
Copy link
Contributor

ktoso commented Nov 14, 2017

Though mostly just for the sake of consistency, please add these to all modules (tck, examples)?

@ktoso
Copy link
Contributor

ktoso commented Nov 14, 2017

Looks good in general though, adding this metadata is very important indeed

@viktorklang
Copy link
Contributor

Hi @kiiadi, Would you mind adding the metadata to all the modules? Something like this: 26b086b ?

@viktorklang
Copy link
Contributor

@ktoso Does this make sense from a module-name PoV: 26b086b

@kiiadi
Copy link
Contributor Author

kiiadi commented Nov 19, 2017

@viktorklang your commit looks fine to me - let's go with that - we can close this PR.

@ktoso
Copy link
Contributor

ktoso commented Nov 19, 2017

(I commented on the commit, not sure you saw that Victor — all good, would likely drop the api name in the module but having is is still legal)

@viktorklang
Copy link
Contributor

@kiiadi You sure? I'd prefer to have you on that commit id :)

@viktorklang
Copy link
Contributor

@ktoso I don't mind either way. We can drop the "api" suffix on the primary RS jar

@viktorklang
Copy link
Contributor

@reactive-streams/contributors I'll merge this and then add the other module names in a separate PR. Thanks @kiiadi!

@viktorklang
Copy link
Contributor

viktorklang commented Nov 22, 2017

@kiiadi I'll include your commit/pr in this PR here (I resolved the conflict between master/HEAD and your PR as well): #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants